From 478b1af548404d2dffac302e2d67adc69935117c Mon Sep 17 00:00:00 2001
From: serso <serso@serso-laptop.(none)>
Date: Fri, 28 Oct 2011 00:41:03 +0400
Subject: [PATCH] interrupt work thread

---
 .../calculator/model/CalculatorEngine.java    | 52 +++++++++++--------
 .../model/CalculatorEngineTest.java           |  8 +++
 2 files changed, 38 insertions(+), 22 deletions(-)

diff --git a/src/main/java/org/solovyev/android/calculator/model/CalculatorEngine.java b/src/main/java/org/solovyev/android/calculator/model/CalculatorEngine.java
index 040ba0f9..5f5034fe 100644
--- a/src/main/java/org/solovyev/android/calculator/model/CalculatorEngine.java
+++ b/src/main/java/org/solovyev/android/calculator/model/CalculatorEngine.java
@@ -78,6 +78,9 @@ public enum CalculatorEngine {
 	@NotNull
 	private ThreadKiller threadKiller = new AndroidThreadKiller();
 
+	// calculation thread timeout in milliseconds, after timeout thread would be interrupted
+	private int timeout = 2000;
+
 	@NotNull
 	public String format(@NotNull Double value) {
 		return format(value, true);
@@ -191,7 +194,7 @@ public enum CalculatorEngine {
 
 				try {
 					//Log.d(CalculatorEngine.class.getName(), "Main thread is waiting: " + Thread.currentThread().getName());
-					latch.await(2, TimeUnit.SECONDS);
+					latch.await(timeout, TimeUnit.MILLISECONDS);
 					//Log.d(CalculatorEngine.class.getName(), "Main thread got up: " + Thread.currentThread().getName());
 
 					final ParseException evalErrorLocal = exception.getObject();
@@ -281,30 +284,35 @@ public enum CalculatorEngine {
 		return varsRegister;
 	}
 
+	// for tests
+	void setTimeout(int timeout) {
+		this.timeout = timeout;
+	}
+
 	/*	private String commands(String str) {
-			return commands(str, false);
-		}
-
-
-		private void exec(String str) throws EvalError {
-			interpreter.eval(str);
-		}
-
-		private String eval(String str) throws EvalError {
-			return interpreter.eval(commands(str)).toString();
-		}
-
-		private String commands(String str, boolean found) {
-			for (int i = 0; i < cmds.length; i++) {
-				int n = str.length() - cmds[i].length() - 1;
-				if (n >= 0 && (" " + cmds[i].toLowerCase()).equals(str.substring(n)))
-					return commands(str.substring(0, n), true) + "." + cmds[i] + "()";
+				return commands(str, false);
 			}
-			str = str.replaceAll("\n", "");
-			return found ? "jscl.math.Expression.valueOf(\"" + str + "\")" : str;
-		}
 
-		private static final String cmds[] = new String[]{"expand", "factorize", "elementary", "simplify", "numeric", "toMathML", "toJava"};*/
+
+			private void exec(String str) throws EvalError {
+				interpreter.eval(str);
+			}
+
+			private String eval(String str) throws EvalError {
+				return interpreter.eval(commands(str)).toString();
+			}
+
+			private String commands(String str, boolean found) {
+				for (int i = 0; i < cmds.length; i++) {
+					int n = str.length() - cmds[i].length() - 1;
+					if (n >= 0 && (" " + cmds[i].toLowerCase()).equals(str.substring(n)))
+						return commands(str.substring(0, n), true) + "." + cmds[i] + "()";
+				}
+				str = str.replaceAll("\n", "");
+				return found ? "jscl.math.Expression.valueOf(\"" + str + "\")" : str;
+			}
+
+			private static final String cmds[] = new String[]{"expand", "factorize", "elementary", "simplify", "numeric", "toMathML", "toJava"};*/
 
 	// for tests only
 	void setThreadKiller(@NotNull ThreadKiller threadKiller) {
diff --git a/src/test/java/org/solovyev/android/calculator/model/CalculatorEngineTest.java b/src/test/java/org/solovyev/android/calculator/model/CalculatorEngineTest.java
index c4af15c4..2401112e 100644
--- a/src/test/java/org/solovyev/android/calculator/model/CalculatorEngineTest.java
+++ b/src/test/java/org/solovyev/android/calculator/model/CalculatorEngineTest.java
@@ -117,6 +117,14 @@ public class CalculatorEngineTest {
 				junit.framework.Assert.fail();
 			}
 		}
+
+		try {
+			cm.setTimeout(5000);
+			Assert.assertEquals("2", cm.evaluate(JsclOperation.numeric, "2!").getResult());
+		} finally {
+			cm.setTimeout(2000);
+		}
+
 	}
 
 	@Test