From 794789e01fa845a14a25c4942102b06c10e677e3 Mon Sep 17 00:00:00 2001 From: mazunki Date: Tue, 9 Nov 2021 16:49:23 +0100 Subject: [PATCH] explicit null checks are cool --- src/wofi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wofi.c b/src/wofi.c index 4a98631..bb08235 100644 --- a/src/wofi.c +++ b/src/wofi.c @@ -414,13 +414,13 @@ static GtkWidget* create_label(char* mode, char* text, char* search_text, char* if (fp_labeltext == NULL) { fprintf(stderr, "error executing '%s'\n", cmd_labeltext); exit(EXIT_FAILURE); - } else if (fgets(line, sizeof(line), fp_labeltext)) { + } else if (fgets(line, sizeof(line), fp_labeltext) != NULL) { // lastly, read the output of said command, and put it into the text variable to be used for the label widgets // consider using 'printf %.10s as your --pre-display-cmd to limit a string to a determined width. 10 here is an example size += strlen(line+1); // we need place for the \0 of strcpy text = (char *) realloc(text, size); strcpy(text, line); - while (fgets(line, sizeof(line), fp_labeltext)) { + while (fgets(line, sizeof(line), fp_labeltext) != NULL) { size += strlen(line); text = (char *) realloc(text, size); strncat(text, line, size);