Changes
This commit is contained in:
@@ -127,7 +127,13 @@ public class AndroidCalculator implements Calculator, CalculatorEventListener, S
|
||||
return calculator.fireCalculatorEvent(calculatorEventType, data, sequenceId);
|
||||
}
|
||||
|
||||
@Override
|
||||
@NotNull
|
||||
@Override
|
||||
public PreparedExpression prepareExpression(@NotNull String expression) throws CalculatorParseException {
|
||||
return calculator.prepareExpression(expression);
|
||||
}
|
||||
|
||||
@Override
|
||||
public void init() {
|
||||
this.calculator.init();
|
||||
|
||||
|
@@ -1,6 +1,8 @@
|
||||
package org.solovyev.android.calculator.function;
|
||||
|
||||
import android.os.Bundle;
|
||||
import android.os.Parcel;
|
||||
import android.os.Parcelable;
|
||||
import android.support.v4.app.DialogFragment;
|
||||
import android.support.v4.app.FragmentManager;
|
||||
import android.view.LayoutInflater;
|
||||
@@ -13,10 +15,15 @@ import jscl.math.function.IFunction;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
import org.jetbrains.annotations.Nullable;
|
||||
import org.solovyev.android.AndroidUtils2;
|
||||
import org.solovyev.android.calculator.*;
|
||||
import org.solovyev.android.calculator.CalculatorEventData;
|
||||
import org.solovyev.android.calculator.CalculatorEventListener;
|
||||
import org.solovyev.android.calculator.CalculatorEventType;
|
||||
import org.solovyev.android.calculator.CalculatorLocatorImpl;
|
||||
import org.solovyev.android.calculator.R;
|
||||
import org.solovyev.android.calculator.math.edit.MathEntityRemover;
|
||||
import org.solovyev.android.calculator.model.AFunction;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
/**
|
||||
@@ -26,8 +33,10 @@ import java.util.List;
|
||||
*/
|
||||
public class FunctionEditDialogFragment extends DialogFragment implements CalculatorEventListener {
|
||||
|
||||
@NotNull
|
||||
private final Input input;
|
||||
private static final String INPUT = "input";
|
||||
|
||||
@NotNull
|
||||
private Input input;
|
||||
|
||||
public FunctionEditDialogFragment() {
|
||||
this(Input.newInstance());
|
||||
@@ -39,7 +48,16 @@ public class FunctionEditDialogFragment extends DialogFragment implements Calcul
|
||||
|
||||
@Override
|
||||
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
|
||||
return inflater.inflate(R.layout.function_edit, container, false);
|
||||
final View result = inflater.inflate(R.layout.function_edit, container, false);
|
||||
|
||||
if (savedInstanceState != null) {
|
||||
final Parcelable input = savedInstanceState.getParcelable(INPUT);
|
||||
if ( input instanceof Input ) {
|
||||
this.input = (Input)input;
|
||||
}
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -49,7 +67,7 @@ public class FunctionEditDialogFragment extends DialogFragment implements Calcul
|
||||
final FunctionParamsView paramsView = (FunctionParamsView) root.findViewById(R.id.function_params_layout);
|
||||
|
||||
final AFunction.Builder builder;
|
||||
final IFunction function = input.getFunction();
|
||||
final AFunction function = input.getFunction();
|
||||
if (function != null) {
|
||||
builder = new AFunction.Builder(function);
|
||||
} else {
|
||||
@@ -92,12 +110,19 @@ public class FunctionEditDialogFragment extends DialogFragment implements Calcul
|
||||
// EDIT MODE
|
||||
getDialog().setTitle(R.string.function_edit_function);
|
||||
|
||||
Function customFunction = new CustomFunction.Builder(function).create();
|
||||
final Function customFunction = new CustomFunction.Builder(function).create();
|
||||
root.findViewById(R.id.remove_button).setOnClickListener(MathEntityRemover.newFunctionRemover(customFunction, null, this.getActivity(), FunctionEditDialogFragment.this));
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
@Override
|
||||
public void onSaveInstanceState(@NotNull Bundle out) {
|
||||
super.onSaveInstanceState(out);
|
||||
|
||||
out.putParcelable(INPUT, FunctionEditorSaver.readInput(input.getFunction(), getView()));
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onResume() {
|
||||
super.onResume();
|
||||
|
||||
@@ -137,10 +162,50 @@ public class FunctionEditDialogFragment extends DialogFragment implements Calcul
|
||||
AndroidUtils2.showDialog(new FunctionEditDialogFragment(input), "function-editor", fm);
|
||||
}
|
||||
|
||||
public static class Input {
|
||||
public static class Input implements Parcelable {
|
||||
|
||||
@Nullable
|
||||
private IFunction function;
|
||||
public static final Parcelable.Creator<Input> CREATOR = new Creator<Input>() {
|
||||
@Override
|
||||
public Input createFromParcel(@NotNull Parcel in) {
|
||||
return Input.fromParcel(in);
|
||||
}
|
||||
|
||||
@Override
|
||||
public Input[] newArray(int size) {
|
||||
return new Input[size];
|
||||
}
|
||||
};
|
||||
|
||||
private static final Parcelable.Creator<String> STRING_CREATOR = new Creator<String>() {
|
||||
@Override
|
||||
public String createFromParcel(@NotNull Parcel in) {
|
||||
return in.readString();
|
||||
}
|
||||
|
||||
@Override
|
||||
public String[] newArray(int size) {
|
||||
return new String[size];
|
||||
}
|
||||
};
|
||||
|
||||
@NotNull
|
||||
private static Input fromParcel(@NotNull Parcel in) {
|
||||
final Input result = new Input();
|
||||
result.name = in.readString();
|
||||
result.content = in.readString();
|
||||
result.description = in.readString();
|
||||
|
||||
final List<String> parameterNames = new ArrayList<String>();
|
||||
in.readTypedList(parameterNames, STRING_CREATOR);
|
||||
result.parameterNames = parameterNames;
|
||||
|
||||
result.function = (AFunction) in.readSerializable();
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
@Nullable
|
||||
private AFunction function;
|
||||
|
||||
@Nullable
|
||||
private String name;
|
||||
@@ -165,14 +230,7 @@ public class FunctionEditDialogFragment extends DialogFragment implements Calcul
|
||||
@NotNull
|
||||
public static Input newFromFunction(@NotNull IFunction function) {
|
||||
final Input result = new Input();
|
||||
result.function = function;
|
||||
return result;
|
||||
}
|
||||
|
||||
@NotNull
|
||||
public static Input newFromValue(@Nullable String value) {
|
||||
final Input result = new Input();
|
||||
result.content = value;
|
||||
result.function = AFunction.fromIFunction(function);
|
||||
return result;
|
||||
}
|
||||
|
||||
@@ -180,18 +238,23 @@ public class FunctionEditDialogFragment extends DialogFragment implements Calcul
|
||||
public static Input newInstance(@Nullable IFunction function,
|
||||
@Nullable String name,
|
||||
@Nullable String value,
|
||||
@Nullable String description) {
|
||||
@Nullable String description,
|
||||
@NotNull List<String> parameterNames) {
|
||||
|
||||
final Input result = new Input();
|
||||
result.function = function;
|
||||
result.name = name;
|
||||
if (function != null) {
|
||||
result.function = AFunction.fromIFunction(function);
|
||||
}
|
||||
result.name = name;
|
||||
result.content = value;
|
||||
result.description = description;
|
||||
result.parameterNames = new ArrayList<String>(parameterNames);
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
@Nullable
|
||||
public IFunction getFunction() {
|
||||
public AFunction getFunction() {
|
||||
return function;
|
||||
}
|
||||
|
||||
@@ -214,5 +277,19 @@ public class FunctionEditDialogFragment extends DialogFragment implements Calcul
|
||||
public List<String> getParameterNames() {
|
||||
return parameterNames == null ? (function == null ? null : function.getParameterNames()) : parameterNames;
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public int describeContents() {
|
||||
return 0;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void writeToParcel(@NotNull Parcel out, int flags) {
|
||||
out.writeString(name);
|
||||
out.writeString(content);
|
||||
out.writeString(description);
|
||||
out.writeList(parameterNames);
|
||||
out.writeSerializable(function);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
@@ -18,6 +18,7 @@ import org.solovyev.android.calculator.model.MathEntityBuilder;
|
||||
import org.solovyev.common.msg.MessageType;
|
||||
import org.solovyev.common.text.StringUtils;
|
||||
|
||||
import java.util.Collections;
|
||||
import java.util.List;
|
||||
|
||||
public class FunctionEditorSaver implements View.OnClickListener {
|
||||
@@ -29,7 +30,7 @@ public class FunctionEditorSaver implements View.OnClickListener {
|
||||
private final AFunction.Builder builder;
|
||||
|
||||
@Nullable
|
||||
private final Function editedInstance;
|
||||
private final IFunction editedInstance;
|
||||
|
||||
@NotNull
|
||||
private final View view;
|
||||
@@ -45,11 +46,7 @@ public class FunctionEditorSaver implements View.OnClickListener {
|
||||
@NotNull Object source) {
|
||||
|
||||
this.builder = builder;
|
||||
if (editedInstance instanceof Function || editedInstance == null) {
|
||||
this.editedInstance = (Function)editedInstance;
|
||||
} else {
|
||||
throw new IllegalArgumentException();
|
||||
}
|
||||
this.editedInstance = editedInstance;
|
||||
this.view = view;
|
||||
this.mathRegistry = registry;
|
||||
this.source = source;
|
||||
@@ -59,17 +56,16 @@ public class FunctionEditorSaver implements View.OnClickListener {
|
||||
public void onClick(View v) {
|
||||
final Integer error;
|
||||
|
||||
final EditText editName = (EditText) view.findViewById(R.id.function_edit_name);
|
||||
String name = editName.getText().toString();
|
||||
final FunctionEditDialogFragment.Input input = readInput(null, view);
|
||||
|
||||
final EditText editValue = (EditText) view.findViewById(R.id.function_edit_value);
|
||||
String content = editValue.getText().toString();
|
||||
final String name = input.getName();
|
||||
final String content = input.getContent();
|
||||
final String description = input.getDescription();
|
||||
|
||||
final EditText editDescription = (EditText) view.findViewById(R.id.function_edit_description);
|
||||
String description = editDescription.getText().toString();
|
||||
|
||||
final FunctionParamsView editParams = (FunctionParamsView) view.findViewById(R.id.function_params_layout);
|
||||
List<String> parameterNames = editParams.getParameterNames();
|
||||
List<String> parameterNames = input.getParameterNames();
|
||||
if ( parameterNames == null ) {
|
||||
parameterNames = Collections.emptyList();
|
||||
}
|
||||
|
||||
if (VarEditorSaver.isValidName(name)) {
|
||||
|
||||
@@ -111,10 +107,29 @@ public class FunctionEditorSaver implements View.OnClickListener {
|
||||
CalculatorFunctionsMathRegistry.saveFunction(mathRegistry, new BuilderAdapter(builder), editedInstance, source, true);
|
||||
} catch (CustomFunctionCalculationException e) {
|
||||
CalculatorLocatorImpl.getInstance().getNotifier().showMessage(e);
|
||||
}
|
||||
} catch (AFunction.Builder.CreationException e) {
|
||||
CalculatorLocatorImpl.getInstance().getNotifier().showMessage(e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@NotNull
|
||||
public static FunctionEditDialogFragment.Input readInput(@Nullable IFunction function, @NotNull View root) {
|
||||
final EditText editName = (EditText) root.findViewById(R.id.function_edit_name);
|
||||
String name = editName.getText().toString();
|
||||
|
||||
final EditText editValue = (EditText) root.findViewById(R.id.function_edit_value);
|
||||
String content = editValue.getText().toString();
|
||||
|
||||
final EditText editDescription = (EditText) root.findViewById(R.id.function_edit_description);
|
||||
String description = editDescription.getText().toString();
|
||||
|
||||
final FunctionParamsView editParams = (FunctionParamsView) root.findViewById(R.id.function_params_layout);
|
||||
List<String> parameterNames = editParams.getParameterNames();
|
||||
|
||||
return FunctionEditDialogFragment.Input.newInstance(function, name, content, description, parameterNames);
|
||||
}
|
||||
|
||||
private boolean validateParameters(@NotNull List<String> parameterNames) {
|
||||
for (String parameterName : parameterNames) {
|
||||
if ( !VarEditorSaver.isValidName(parameterName) ) {
|
||||
|
@@ -0,0 +1,34 @@
|
||||
package org.solovyev.android.calculator.function;
|
||||
|
||||
import android.content.Context;
|
||||
import android.os.Parcelable;
|
||||
import android.util.AttributeSet;
|
||||
import android.view.AbsSavedState;
|
||||
import android.widget.EditText;
|
||||
|
||||
public class FunctionParamEditText extends EditText {
|
||||
|
||||
public FunctionParamEditText(Context context) {
|
||||
super(context);
|
||||
}
|
||||
|
||||
public FunctionParamEditText(Context context, AttributeSet attrs) {
|
||||
super(context, attrs);
|
||||
}
|
||||
|
||||
public FunctionParamEditText(Context context, AttributeSet attrs, int defStyle) {
|
||||
super(context, attrs, defStyle);
|
||||
}
|
||||
|
||||
// we restore state manually outside
|
||||
@Override
|
||||
public Parcelable onSaveInstanceState() {
|
||||
super.onSaveInstanceState();
|
||||
return AbsSavedState.EMPTY_STATE;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onRestoreInstanceState(Parcelable state) {
|
||||
super.onRestoreInstanceState(null);
|
||||
}
|
||||
}
|
@@ -294,7 +294,12 @@ public abstract class AbstractMathEntityListFragment<T extends MathEntity> exten
|
||||
}
|
||||
}
|
||||
|
||||
@NotNull
|
||||
@Nullable
|
||||
protected MathEntityArrayAdapter<T> getAdapter() {
|
||||
return adapter;
|
||||
}
|
||||
|
||||
@NotNull
|
||||
protected Handler getUiHandler() {
|
||||
return uiHandler;
|
||||
}
|
||||
|
@@ -18,7 +18,12 @@ import jscl.math.function.Function;
|
||||
import jscl.math.function.IFunction;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
import org.jetbrains.annotations.Nullable;
|
||||
import org.solovyev.android.calculator.*;
|
||||
import org.solovyev.android.calculator.CalculatorEventData;
|
||||
import org.solovyev.android.calculator.CalculatorEventType;
|
||||
import org.solovyev.android.calculator.CalculatorLocatorImpl;
|
||||
import org.solovyev.android.calculator.CalculatorMathRegistry;
|
||||
import org.solovyev.android.calculator.Change;
|
||||
import org.solovyev.android.calculator.R;
|
||||
import org.solovyev.android.calculator.about.CalculatorFragmentType;
|
||||
import org.solovyev.android.calculator.function.FunctionEditDialogFragment;
|
||||
import org.solovyev.android.menu.AMenuItem;
|
||||
@@ -126,7 +131,7 @@ public class CalculatorFunctionsFragment extends AbstractMathEntityListFragment<
|
||||
break;
|
||||
|
||||
case function_changed:
|
||||
processFunctionChanged((Change<Function>) data);
|
||||
processFunctionChanged((Change<IFunction>) data);
|
||||
break;
|
||||
|
||||
case function_removed:
|
||||
@@ -148,19 +153,40 @@ public class CalculatorFunctionsFragment extends AbstractMathEntityListFragment<
|
||||
}
|
||||
}
|
||||
|
||||
private void processFunctionChanged(@NotNull final Change<Function> change) {
|
||||
final Function newFunction = change.getNewValue();
|
||||
if (this.isInCategory(newFunction)) {
|
||||
getUiHandler().post(new Runnable() {
|
||||
@Override
|
||||
public void run() {
|
||||
removeFromAdapter(change.getOldValue());
|
||||
addToAdapter(newFunction);
|
||||
sort();
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
private void processFunctionChanged(@NotNull final Change<IFunction> change) {
|
||||
final IFunction newFunction = change.getNewValue();
|
||||
|
||||
if (newFunction instanceof Function) {
|
||||
|
||||
if (this.isInCategory((Function)newFunction)) {
|
||||
|
||||
getUiHandler().post(new Runnable() {
|
||||
@Override
|
||||
public void run() {
|
||||
IFunction oldValue = change.getOldValue();
|
||||
|
||||
if (oldValue.isIdDefined()) {
|
||||
final MathEntityArrayAdapter<Function> adapter = getAdapter();
|
||||
if ( adapter != null ) {
|
||||
for (int i = 0; i < adapter.getCount(); i++) {
|
||||
final Function functionFromAdapter = adapter.getItem(i);
|
||||
if ( functionFromAdapter.isIdDefined() && oldValue.getId().equals(functionFromAdapter.getId()) ) {
|
||||
adapter.remove(functionFromAdapter);
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
addToAdapter((Function)newFunction);
|
||||
sort();
|
||||
}
|
||||
});
|
||||
}
|
||||
} else {
|
||||
throw new IllegalArgumentException("Function must be instance of jscl.math.function.Function class!");
|
||||
}
|
||||
}
|
||||
|
||||
private void processFunctionAdded(@NotNull final Function function) {
|
||||
if (this.isInCategory(function)) {
|
||||
|
Reference in New Issue
Block a user