TnSb/wofi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

That's not a very effective null check

Browse Source
This commit is contained in:
Scoopta 2020-02-07 18:10:06 -08:00
parent 28be2d8234
commit 6f2e4616ab
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wofi.c
View File

@ -841,6 +841,9 @@ static gint do_sort(GtkFlowBoxChild* child1, GtkFlowBoxChild* child2, gpointer d
const gchar* text2 = wofi_property_box_get_property(WOFI_PROPERTY_BOX(box2), "filter"); const gchar* text2 = wofi_property_box_get_property(WOFI_PROPERTY_BOX(box2), "filter");
uint64_t index1 = strtol(wofi_property_box_get_property(WOFI_PROPERTY_BOX(box1), "index"), NULL, 10); uint64_t index1 = strtol(wofi_property_box_get_property(WOFI_PROPERTY_BOX(box1), "index"), NULL, 10);
uint64_t index2 = strtol(wofi_property_box_get_property(WOFI_PROPERTY_BOX(box2), "index"), NULL, 10); uint64_t index2 = strtol(wofi_property_box_get_property(WOFI_PROPERTY_BOX(box2), "index"), NULL, 10);
if(text1 == NULL || text2 == NULL) {
return index1 - index2;
}
if(filter == NULL || strcmp(filter, "") == 0) { if(filter == NULL || strcmp(filter, "") == 0) {
switch(sort_order) { switch(sort_order) {
case SORT_ORDER_DEFAULT: case SORT_ORDER_DEFAULT:
@ -849,9 +852,6 @@ static gint do_sort(GtkFlowBoxChild* child1, GtkFlowBoxChild* child2, gpointer d
return strcmp(text1, text2); return strcmp(text1, text2);
} }
} }
if(text1 == NULL || text2 == NULL) {
return index1 - index2;
}
switch(matching) { switch(matching) {
case MATCHING_MODE_CONTAINS: case MATCHING_MODE_CONTAINS: